Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: upgrade grpc to v1.47.0 #88470

Merged
merged 1 commit into from
Sep 22, 2022
Merged

Conversation

pav-kv
Copy link
Collaborator

@pav-kv pav-kv commented Sep 22, 2022

Fixes #81227

Release note: upgrade grpc from v1.46.0 to v.1.47.0 which fixes a subtle bug
causing panic on a nil pointer.

@pav-kv pav-kv requested a review from a team as a code owner September 22, 2022 15:33
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Contributor

@erikgrinaker erikgrinaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but we should squash this into a single commit so the deps aren't out of sync on the first one.

Fixes cockroachdb#81227

Release note: upgrade grpc from v1.46.0 to v.1.47.0 which fixes a subtle bug
causing panic on a nil pointer.
@pav-kv
Copy link
Collaborator Author

pav-kv commented Sep 22, 2022

bors r=erikgrinaker

@craig
Copy link
Contributor

craig bot commented Sep 22, 2022

Build failed:

@pav-kv
Copy link
Collaborator Author

pav-kv commented Sep 22, 2022

bors retry

@craig
Copy link
Contributor

craig bot commented Sep 22, 2022

Build succeeded:

@craig craig bot merged commit dc1fd19 into cockroachdb:master Sep 22, 2022
@pav-kv pav-kv deleted the upd_grcp_to_1_47 branch September 22, 2022 22:18
@pav-kv
Copy link
Collaborator Author

pav-kv commented Sep 22, 2022

blathers backport 22.2

@blathers-crl
Copy link

blathers-crl bot commented Sep 22, 2022

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error creating merge commit from a2089f9 to blathers/backport-release-22.2-88470: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 22.2 failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kvserver: v21.2.7: nil pointer in gRPC transport when sending snapshots
3 participants